From 697ef5940faa71d96207d532a885d20e7b0494cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=A6=8C=20=EA=A6=AB=EA=A6=B6=20=EA=A6=8F=EA=A7=80?= =?UTF-8?q?=EA=A6=A6=EA=A6=BF=20=EA=A6=A7=20=EA=A6=AE=20=EA=A6=91=20?= =?UTF-8?q?=EA=A6=A9=20=EA=A6=AD=EA=A7=80?= Date: Thu, 3 Oct 2019 18:43:52 +0800 Subject: Prepare rowCount property so it can be accessed in QML --- qrtclient/tickethistory.hxx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qrtclient/tickethistory.hxx b/qrtclient/tickethistory.hxx index 7d68652..2d766f6 100644 --- a/qrtclient/tickethistory.hxx +++ b/qrtclient/tickethistory.hxx @@ -63,6 +63,7 @@ namespace RTClient { class TicketHistoryList : public QAbstractListModel { Q_OBJECT + Q_PROPERTY(int rowCount READ rowCount NOTIFY rowCountChanged) public: enum TicketHistoryRoles { @@ -97,6 +98,7 @@ namespace RTClient { QHash roleNames() const Q_DECL_OVERRIDE; signals: + void rowCountChanged(); void updated(); private: -- cgit v1.2.3 From 232dd5211cd30774274cbbfc971b3489a8bcf200 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=A6=8C=20=EA=A6=AB=EA=A6=B6=20=EA=A6=8F=EA=A7=80?= =?UTF-8?q?=EA=A6=A6=EA=A6=BF=20=EA=A6=A7=20=EA=A6=AE=20=EA=A6=91=20?= =?UTF-8?q?=EA=A6=A9=20=EA=A6=AD=EA=A7=80?= Date: Sat, 5 Oct 2019 14:51:36 +0800 Subject: updated signal is emitted only when the list *is* updated --- qrtclient/ticket.hxx | 2 +- ticket.cxx | 12 ++++++------ tickethistory.cxx | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/qrtclient/ticket.hxx b/qrtclient/ticket.hxx index d02954b..44f5a08 100644 --- a/qrtclient/ticket.hxx +++ b/qrtclient/ticket.hxx @@ -45,7 +45,7 @@ namespace RTClient { ) const Q_DECL_OVERRIDE; public slots: - void update(rtclient_search_ticket_list* ticketList); + void update(rtclient_search_ticket_list* list); protected: QHash roleNames() const Q_DECL_OVERRIDE; diff --git a/ticket.cxx b/ticket.cxx index 4693225..7b21bc8 100644 --- a/ticket.cxx +++ b/ticket.cxx @@ -42,14 +42,14 @@ namespace RTClient { emit rowCountChanged(); } - void TicketList::update(rtclient_search_ticket_list* ticketList) + void TicketList::update(rtclient_search_ticket_list* list) { - if (ticketList) { - for (size_t i = 0; i < ticketList->length; i++) - addTicket(Ticket{ticketList->tickets[i]}); - rtclient_search_ticket_free(ticketList); + if (list) { + for (size_t i = 0; i < list->length; i++) + addTicket(Ticket{list->tickets[i]}); + rtclient_search_ticket_free(list); + emit updated(); } - emit updated(); } } diff --git a/tickethistory.cxx b/tickethistory.cxx index 4243d7c..80fc478 100644 --- a/tickethistory.cxx +++ b/tickethistory.cxx @@ -83,8 +83,8 @@ namespace RTClient { addTicketHistory (TicketHistory{list->histories[i]}); rtclient_ticket_history_list_free(list); + emit updated(); } - emit updated(); } } -- cgit v1.2.3 From c92f1706f0c54e360c255555ba68a96c967dabfa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=A6=8C=20=EA=A6=AB=EA=A6=B6=20=EA=A6=8F=EA=A7=80?= =?UTF-8?q?=EA=A6=A6=EA=A6=BF=20=EA=A6=A7=20=EA=A6=AE=20=EA=A6=91=20?= =?UTF-8?q?=EA=A6=A9=20=EA=A6=AD=EA=A7=80?= Date: Sun, 6 Oct 2019 22:06:17 +0800 Subject: librtclient syntax simplification --- librtclient | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/librtclient b/librtclient index 6012511..abaaef6 160000 --- a/librtclient +++ b/librtclient @@ -1 +1 @@ -Subproject commit 601251148de5bd8a42649e3b888d7824eb1d7743 +Subproject commit abaaef65e251fe5c39f01349e172e7d85c8d6788 -- cgit v1.2.3 From bda8b2b7402570251ac1008e2b964f369fe0bedd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=A6=8C=20=EA=A6=AB=EA=A6=B6=20=EA=A6=8F=EA=A7=80?= =?UTF-8?q?=EA=A6=A6=EA=A6=BF=20=EA=A6=A7=20=EA=A6=AE=20=EA=A6=91=20?= =?UTF-8?q?=EA=A6=A9=20=EA=A6=AD=EA=A7=80?= Date: Sun, 6 Oct 2019 22:45:48 +0800 Subject: librtclient update and variable name shortening --- client.cxx | 6 +++--- librtclient | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client.cxx b/client.cxx index 6711461..ed24ef2 100644 --- a/client.cxx +++ b/client.cxx @@ -116,9 +116,9 @@ namespace RTClient { void Client::searchTicket(QString const& owner) { QString query{"Owner='" % owner % "'"}; - rtclient_search_ticket_list* ticketList = nullptr; - rtclient_search_ticket(&ticketList, query.toLatin1().constData()); - emit searchedTicket(ticketList); + rtclient_search_ticket_list* list = nullptr; + rtclient_search_ticket(&list, query.toLatin1().constData()); + emit searchedTicket(list); } void Client::ticketHistory(int id, bool longFormat) diff --git a/librtclient b/librtclient index abaaef6..7580502 160000 --- a/librtclient +++ b/librtclient @@ -1 +1 @@ -Subproject commit abaaef65e251fe5c39f01349e172e7d85c8d6788 +Subproject commit 758050268f93c45e0eda1f7b39bb080ab212c97d -- cgit v1.2.3 From ba0b288a7990dc33b67d50c6beebaa11d0aaf66b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=A6=8C=20=EA=A6=AB=EA=A6=B6=20=EA=A6=8F=EA=A7=80?= =?UTF-8?q?=EA=A6=A6=EA=A6=BF=20=EA=A6=A7=20=EA=A6=AE=20=EA=A6=91=20?= =?UTF-8?q?=EA=A6=A9=20=EA=A6=AD=EA=A7=80?= Date: Sun, 6 Oct 2019 22:58:17 +0800 Subject: librtclient update --- librtclient | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/librtclient b/librtclient index 7580502..e52b9d5 160000 --- a/librtclient +++ b/librtclient @@ -1 +1 @@ -Subproject commit 758050268f93c45e0eda1f7b39bb080ab212c97d +Subproject commit e52b9d5cebd750bcebcf0d65c7df695be5158dae -- cgit v1.2.3 From 5b81cf57054afc9ded05f0edcfa2e232731de051 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=A6=8C=20=EA=A6=AB=EA=A6=B6=20=EA=A6=8F=EA=A7=80?= =?UTF-8?q?=EA=A6=A6=EA=A6=BF=20=EA=A6=A7=20=EA=A6=AE=20=EA=A6=91=20?= =?UTF-8?q?=EA=A6=A9=20=EA=A6=AD=EA=A7=80?= Date: Mon, 7 Oct 2019 09:44:22 +0800 Subject: librtclient various simplifications --- librtclient | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/librtclient b/librtclient index e52b9d5..e2ef30a 160000 --- a/librtclient +++ b/librtclient @@ -1 +1 @@ -Subproject commit e52b9d5cebd750bcebcf0d65c7df695be5158dae +Subproject commit e2ef30abf57dc9d94ec15e5a56a2568f0aa1e06b -- cgit v1.2.3 From 0cf274af73740a4ee48f18a66a63b6cc8355c9ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=A6=8C=20=EA=A6=AB=EA=A6=B6=20=EA=A6=8F=EA=A7=80?= =?UTF-8?q?=EA=A6=A6=EA=A6=BF=20=EA=A6=A7=20=EA=A6=AE=20=EA=A6=91=20?= =?UTF-8?q?=EA=A6=A9=20=EA=A6=AD=EA=A7=80?= Date: Mon, 7 Oct 2019 10:13:42 +0800 Subject: librtclient fix --- librtclient | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/librtclient b/librtclient index e2ef30a..280d890 160000 --- a/librtclient +++ b/librtclient @@ -1 +1 @@ -Subproject commit e2ef30abf57dc9d94ec15e5a56a2568f0aa1e06b +Subproject commit 280d890edd60196c496f92f969ab31e5ecbcaa0b -- cgit v1.2.3